Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error.js to typescript types #636

Merged
merged 3 commits into from
Feb 23, 2020
Merged

Conversation

uc4w6c
Copy link
Contributor

@uc4w6c uc4w6c commented Feb 5, 2020

add #616
Nice to meet you

This is to export error classes from error.js

@uc4w6c
Copy link
Contributor Author

uc4w6c commented Feb 6, 2020

I don't know why it fails

@uc4w6c uc4w6c closed this Feb 6, 2020
@uc4w6c uc4w6c deleted the typesafe-error branch February 6, 2020 12:41
@tulios
Copy link
Owner

tulios commented Feb 6, 2020

@uc4w6c I will take a look, it might just be a flaky test. I can re-run the group that is failing. Should I re-open the PR?

@uc4w6c uc4w6c restored the typesafe-error branch February 6, 2020 12:55
@uc4w6c
Copy link
Contributor Author

uc4w6c commented Feb 6, 2020

@tulios
Really?
Thank you by all means.

@uc4w6c uc4w6c reopened this Feb 6, 2020
@Nevon Nevon merged commit 43e3028 into tulios:master Feb 23, 2020
@Nevon
Copy link
Collaborator

Nevon commented Feb 23, 2020

Sorry that it took some time to get to this.

@uc4w6c uc4w6c deleted the typesafe-error branch February 23, 2020 12:08
@uc4w6c
Copy link
Contributor Author

uc4w6c commented Feb 23, 2020

@Nevon
I'm happy!!
Special thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants