Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent changes in the subscriptions for running consumers #470

Merged

Conversation

ankon
Copy link
Contributor

@ankon ankon commented Aug 16, 2019

Such changes would be ignored by the consumer, so we better fail very on.


This is mainly to avoid frustration for users, an issue for being able to change the subscriptions for a running consumer will come as well

@Nevon Nevon merged commit e21c04d into tulios:master Aug 18, 2019
@ankon ankon deleted the pr/prevent-subscription-change-for-consumer branch August 19, 2019 07:54
@tulios
Copy link
Owner

tulios commented Aug 19, 2019

Pre-release 1.11.0-beta.5 was published with this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants