Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't modify global.crypto #365

Merged
merged 1 commit into from
May 20, 2019
Merged

Don't modify global.crypto #365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 12 additions & 14 deletions src/producer/partitioners/default/randomBytes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,16 @@
const { KafkaJSNonRetriableError } = require('../../../errors')

if (typeof global !== 'undefined' && !global.crypto) {
global.crypto = require('crypto')
const toNodeCompatible = crypto => ({
randomBytes: size => crypto.getRandomValues(Buffer.allocUnsafe(size)),
})

let cryptoImplementation = null
if (global && global.crypto) {
cryptoImplementation = toNodeCompatible(global.crypto)
} else if (global && global.msCrypto) {
cryptoImplementation = toNodeCompatible(global.msCrypto)
} else if (global && !global.crypto) {
cryptoImplementation = require('crypto')
}

const MAX_BYTES = 65536
Expand All @@ -13,20 +22,9 @@ module.exports = size => {
)
}

if (typeof global.crypto !== 'undefined' && global.crypto.randomBytes) {
return global.crypto.randomBytes(size)
}

let cryptoImplementation
if (typeof global.crypto !== 'undefined') {
cryptoImplementation = global.crypto
} else if (typeof global.msCrypto !== 'undefined') {
cryptoImplementation = global.msCrypto
}

if (!cryptoImplementation) {
throw new KafkaJSNonRetriableError('No available crypto implementation')
}

return cryptoImplementation.getRandomValues(Buffer.allocUnsafe(size))
return cryptoImplementation.randomBytes(size)
}