Better handle empty control batches #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienvincent
force-pushed
the
fix/batch-monitoring
branch
from
cd95cf2
to
af7c429
Compare
julienvincent
force-pushed
the
fix/batch-monitoring
branch
from
f546f8b
to
57b38d1
Compare
julienvincent
changed the title
julienvincent
force-pushed
the
fix/batch-monitoring
branch
2 times, most recently
from
6523ea5
to
0480ed5
Compare
|
@Nevon happy to merge? |
|
@Nevon Looks like the pipeline had an ephemeral network failure. Can you re-trigger the jobs? |
|
Triggered another run now. Not sure if the Azure DevOps Github integration is smart enough for the build status notifications to work. If not, you can always push an empty commit to trigger it. |
julienvincent
force-pushed
the
fix/batch-monitoring
branch
from
a30c457
to
0fa1aa4
Compare
|
@Nevon Ok, I re-pushed to force the jobs. All is passing 👍 |
|
Hey @Nevon, any chance I could get some eyes on this? |
|
Next week I will have some time to spend on KafkaJS, and will make sure that this is high up on the todo list. |
|
Thanks! 🙏 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a two part fix for transactionally aware consumers that are processing aborted transactions.
Instrumentation Events
The problem with the current implementation is that if a batch containing only control records or only aborted messages is received then there is no way for monitors to be aware that the consumer progressed. This can happen, for example, when reading aborted transactions.
This is fixed by emitting start and end batch instrumentation events if the batch is an empty control batch or only contains aborted messages.
Consume Lockout
Secondarily there exists an issue wherein if a batch containing only aborted messages or only control messages is received then the consumer never resolves + commits the batch offset, resulting in the consumer processing the same batch repeatedly and getting blocked.
Similarly to the previous scenario, this is fixed by checking for this scenario and resolving + auto-committing the batches latest offset.