Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change sent metadata topic array to be nullable (versions 1, 2 and 3) #1184

Merged
merged 2 commits into from
Feb 8, 2022

Conversation

pdrvsky
Copy link

@pdrvsky pdrvsky commented Sep 13, 2021

According to a documentation and some research in other libs I've fixed topic metadata fetching in Kafka protocol versions 1, 2 and 3. It used a v0 version, which sent an empty array not a -1 value.

@Nevon
Copy link
Collaborator

Nevon commented Feb 8, 2022

It's weird that the Kafka protocol guide doesn't mention anything about Metadata v0 expecting an array, but indeed the definition of a zero length array is null, so this change makes sense.

@Nevon Nevon merged commit 5fe4004 into tulios:master Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants