Merge pull request #985 from t-d-d/pr/array_push

Use Array.push() instead of spread/concat
tulios · Dec 11, 2020 · ba34eef · ba34eef
2 parents e1cefda + 0c3fe64
commit ba34eef
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/protocol/requests/fetch/v4/decodeMessages.js b/src/protocol/requests/fetch/v4/decodeMessages.js
@@ -20,12 +20,12 @@ const decodeMessages = async decoder => {
   const magicByte = messagesBuffer.slice(MAGIC_OFFSET).readInt8(0)
 
   if (magicByte === MAGIC_BYTE) {
-    let records = []
+    const records = []
 
     while (messagesDecoder.canReadBytes(RECORD_BATCH_OVERHEAD)) {
       try {
         const recordBatch = await RecordBatchDecoder(messagesDecoder)
-        records = [...records, ...recordBatch.records]
+        records.push(...recordBatch.records)
       } catch (e) {
         // The tail of the record batches can have incomplete records
         // due to how maxBytes works. See https://cwiki.apache.org/confluence/display/KAFKA/A+Guide+To+The+Kafka+Protocol#AGuideToTheKafkaProtocol-FetchAPI