Properly validate topicMessages

tulios · Jun 29, 2018 · a5a8f12 · a5a8f12
1 parent c231143
commit a5a8f12
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/producer/index.js b/src/producer/index.js
@@ -32,8 +32,8 @@ module.exports = ({
    * @param {SendBatchRequest}
    * @returns {Promise}
    */
-  const sendBatch = async ({ acks, timeout, compression, topicMessages }) => {
-    if (topicMessages && topicMessages.length > 0 && topicMessages.some(({ topic }) => !topic)) {
+  const sendBatch = async ({ acks, timeout, compression, topicMessages = [] }) => {
+    if (topicMessages.length === 0 || topicMessages.some(({ topic }) => !topic)) {
       throw new KafkaJSNonRetriableError(`Invalid topic`)
     }