Skip to content

Add strings catalog parser #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2024
Merged

Add strings catalog parser #9

merged 1 commit into from
Jun 17, 2024

Conversation

@leszko11
Copy link
Contributor

Hey there 👋

I'm trying to update tuist/tuist#6296 PR
stringsCatalog enum case is needed here

@fortmarek fortmarek merged commit 614c419 into tuist:main Jun 17, 2024
fortmarek added a commit that referenced this pull request Jul 30, 2024
@fortmarek
Revert "Add strings catalog parser (#9)"
6148bfd 
This reverts commit 614c419.
@fortmarek fortmarek mentioned this pull request Jul 30, 2024
Merged
fortmarek added a commit that referenced this pull request Jul 30, 2024
@fortmarek
Revert breaking changes (#25)
003abc2 
* Revert "Add strings catalog parser (#9)"

This reverts commit 614c419.

* Revert "Defer binary path for platform"

This reverts commit 0f6fa6f.
@fortmarek
Copy link
Member

@leszko11 would you mind reopening this PR? We decided to revert it as it was a breaking change in tuist/tuist and the PR fixing those changes is not merged nor approved. We can merge this again once the tuist/tuist PR is approved and the CI for it passes.

@leszko11 leszko11 mentioned this pull request Aug 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fortmarek fortmarek fortmarek approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@leszko11 @fortmarek