Skip to content

Conversation

@Binlogo
Copy link
Collaborator

@Binlogo Binlogo commented Jun 17, 2024

Resolve #11

Since the XCFramework is a bundle support for multiple platforms, it‘s difficult to say which binary is the primary binary. It is better to keep the platform in the binary library and defer which to use when it is needed.

@Binlogo Binlogo force-pushed the feat/xcframework-platforms branch from 8ef6597 to 0f6fa6f Compare June 18, 2024 02:14
@Binlogo Binlogo marked this pull request as draft June 18, 2024 02:29
@Binlogo Binlogo marked this pull request as ready for review June 19, 2024 01:45
Copy link
Member

@fortmarek fortmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's merge this once we get approval for the related PR: tuist/tuist#6414

@pepicrft pepicrft merged commit a4c70bf into tuist:main Jun 21, 2024
@pepicrft
Copy link
Contributor

I'm creating a new release with the changes. Thanks a lot @Binlogo for these.

@Binlogo Binlogo deleted the feat/xcframework-platforms branch June 21, 2024 08:32
@fortmarek fortmarek mentioned this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XCFrameworkInfoPlist support more platforms

3 participants