Release v2.1.0-rc.2 - #5250
Merged
Merged
Conversation
Back-merge v2.1.0-rc.1 from main into develop
The fix from #5243 ("Fixes #5259. AOT: use source-generated JSON serializer for dictionary construction in DeepCloner") was reverted when release/v2.1.0-rc.1 merged origin/main back at 94dca98. That merge had conflicts in DeepCloner.cs and ConfigurationManager.cs and the resolution picked main's pre-#5243 versions, dropping: - 27 lines from DeepCloner.cs (the SourceGenerationContext.GetTypeInfo fallback in CreateDictionaryInstance, plus its leading comment) and re-adding 54 lines to ConfigurationManager.cs: - CloneHardCodedPropertyValue and the per-type clone helpers (CloneKeyBindings, ClonePlatformKeyBinding, CloneKeyArray) that #5243 had removed in favor of generic DeepCloner handling - the call site change from DeepClone to CloneHardCodedPropertyValue PRs #5246 (rc.1 → main) and #5247 (rc.1 backmerge → develop) carried the broken state forward. v2.1.0-beta.1 was tagged before the merge (no fix); v2.1.0-rc.1 was tagged after but doesn't have it either. Repro: `dotnet publish Examples/NativeAot -c Release -r win-x64 --self-contained -p:PublishAot=true` against current develop crashes at module init with `MissingMethodException: No parameterless constructor defined for type Dictionary<ColorName16, string>`. Same crash a downstream AOT consumer (clet) hit and tracked as #5239 → #5240 → #5242 → #5243 → #5248. This commit checks DeepCloner.cs and ConfigurationManager.cs out of 11d6e27 (the original PR #5243 merge), restoring the source-gen fallback and removing the per-type helpers. Verified locally: - `dotnet build Terminal.Gui/Terminal.Gui.csproj -c Release` → 0 errors - clet AOT publish + `clet.exe --version` runs cleanly (was crashing against rc.1; now exits 0 with the local TG nupkg pinned) Refs #5239, #5242, #5243, #5248, #5259. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 8, 2026
This was referenced May 16, 2026
This was referenced May 25, 2026
This was referenced Jun 15, 2026
This was referenced Jun 29, 2026
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v2.1.0-rc.2
This is a rc pre-release.
Version:
2.1.0-rc.2NuGet Package:
Terminal.Gui 2.1.0-rc.2What happens when this PR is merged
v2.1.0-rc.2main→developwill be openedChecklist
2.1.0-rc.2