Skip to content

Fixes #2305. Improves the handling of escape sequence. - #2375

Merged
tig merged 43 commits into
tui-cs:developfrom
BDisp:escape-sequence-utils_2305
Feb 25, 2023
Merged

Fixes #2305. Improves the handling of escape sequence.#2375
tig merged 43 commits into
tui-cs:developfrom
BDisp:escape-sequence-utils_2305

Conversation

@BDisp

@BDisp BDisp commented Feb 22, 2023

Copy link
Copy Markdown
Collaborator

Fixes #2305 - Added the EscSeqUtils which will handle escape sequences from the NetDriver and the CursesDriver. The mouse management on CursesDriver is now managed with the EscSeqUtils class.

Fixes #1617

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

tig and others added 30 commits January 1, 2023 10:48
…exit-fix

Improves HeightAsBuffer although currently only works on Windows.
…rminal.gui into fixes_2261_scroll_buffer_cleared_on_exit
@tig
tig merged commit 1d2dc40 into tui-cs:develop Feb 25, 2023
@BDisp
BDisp deleted the escape-sequence-utils_2305 branch February 25, 2023 22:50
tznind pushed a commit to tznind/gui.cs that referenced this pull request May 7, 2023
…2375)

* Changed ansi esc sequence used on exit.

* Changed ansi esc sequence used on exit.

* Improves HeightAsBuffer although currently only works on Windows.

* Fixes tui-cs#2267. Toplevel.EnsureVisibleBounds throws an exception if border is null.

* Changing comment as requested.

* Fixes indentation.

* Seems not needed for now, maybe some update, comment for now.

* Renamed HeightAsBuffer to EnableConsoleScrolling and made it obsolete.

* Add comment on remarks for EnableConsoleScrolling.

* merged @BDisp's EnableConsoleScrolling PR

* Fixes buffer for Windows Terminal.

* Fixes issue in Windows Terminal on resizing causing some lines not be drawing after exceptions.

* merge #9

* merged #9

* use ESC [ ? 1047

* Tweaks with new esc codes

* Fixed curses driver to not nuke scroll buffer and to resize properly

* merge

* Cleand up netdriver escape codes

* fixed spaces->tabs

* fixed spaces->tabs

* fixed spaces->tabs

* fixed spaces->tabs

* fixed merge issue and  spaces->tabs

* fixed spaces->tabs

* fixed spaces->tabs

* fixed spaces->tabs

* fixed  build error

* removed old comments

* Resolving merge conflicts.

* Ensuring reset the EnableConsoleScrolling.

* Changing from HeightAsBuffer to EnableConsoleScrolling.

* Done requested changes.

* Reformatting.

* Rename to EscSeqReqStatus.

* Removing Console.Out.Flush ();

---------

Co-authored-by: Charlie Kindel <tig@users.noreply.github.com>
Co-authored-by: Tig Kindel <tig@kindel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The internal NetEvents class is limiting the number of escape sequence to 1, discarding some. Mouse button clicks by itself on certain Linux distro

2 participants