Skip to content

Fixes #2371. V2 needs be merged with develop and be fixed from errors. - #2372

Merged
tig merged 6 commits into
tui-cs:v2from
BDisp:v2-merged-errors-fix_2371
Feb 21, 2023
Merged

Fixes #2371. V2 needs be merged with develop and be fixed from errors.#2372
tig merged 6 commits into
tui-cs:v2from
BDisp:v2-merged-errors-fix_2371

Conversation

@BDisp

@BDisp BDisp commented Feb 21, 2023

Copy link
Copy Markdown
Collaborator

Fixes #2371 - I had to include the #2370.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

BDisp and others added 6 commits February 21, 2023 00:53
…roduce (tui-cs#2332)

* Proves that the issue tui-cs#2331 don't have reason to happen.

* fixes tui-cs#2336

* Fixes tui-cs#2331. ScrollView may not be honoring clip region; CustomButton shows outside

* More appropriate solution for the issue tui-cs#2331.

* Start refactoring LineCanvas for mixing line style support (e.g. double into single)

* Add remaining resolvers

* Implement corner border style mixing in LineCanvas

* Refactor and simplify resolvers

* Move tests to Core folder and namespace to Terminal.Gui.CoreTests

* Fixes tui-cs#2333. TextField is selecting badly a word on double click.

* Add unit test deleting a word with accented char.

* Fixes 2331. ScrollView may not be honoring clip region.

* Add a custom button scenario.

* Fixes tui-cs#2350. Clipping broke (see Clipping scenario).

* Is preferable use NeedDisplay instead of Bounds.

---------

Co-authored-by: Tig Kindel <tig@users.noreply.github.com>
Co-authored-by: tznind <tznind@dundee.ac.uk>
* Add empty snake scenario

* Move snake head around

* Snake now has a tail

* Rest of logic implementation

* Ctrl K D layout fixes

* Game gets faster as you collect more apples

* Adjust speed increase rate down

* Use white on black for snake and border and red for apple

* Fix ScenarioTests not Disposing Scenario

* Add disposes and fix to use LineCanvas.GenerateImage

* Fix stack overflow, doh!

---------

Co-authored-by: Tig <tig@users.noreply.github.com>
@tig
tig merged commit cacfe0d into tui-cs:v2 Feb 21, 2023
@BDisp
BDisp deleted the v2-merged-errors-fix_2371 branch February 21, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants