Fixes #2140. OnSelectedChange is being called from OnEnter when the selection didn't actually change.

[tig]

Fixes #2140.

OnSelectedChange is being called from OnEnter when the selection didn't actually change.

The fix broke ComboBox - this test: HideDropdownListOnClick_True_Highlight_Current_Item ()

System.Exception : Colors used did not match expected at row 1 and col 0 (indexes start at 0). Color index used was Black,Black but test expected Black,Black (these are indexes into the expectedColors array)

Which is confusing to me...

[tig]

@BDisp - since you are familiar with ComboBox, can you please look at this PR and figure out how to adjust ComboBox so that it is no longer dependent on ListView.OnSelectedChanged being called from ListView.OnEnter?

And submit a PR to this PR?

[BDisp]

Ok @tig .

[tznind]

Black,Black but test expected Black,Black

Black was not black enough! :goth:

Maybe we should change this test to do 'by value' rather than 'by reference' comparison on those. Unless it is that the error message is bugged itself.

That said it could just be an issue with the test itself:

[BDisp]

I can't see it right now, but it seems that the background is cleared after it was redraw.

[BDisp]

The extra 0 is the down arrow. I already realized that the errors messages are bugged. The only valid information I get is the row, col and if the color already exists in the variable. But I think that it should inform what the color is in the test and what color it should were be.

[BDisp]

@tig the fix is here #2156 (comment).

[BDisp]

@tig I submitted a PR in your branch tig#4.