Skip to content

Fixes #2137. Disabled menu item is selected on click. - #2138

Merged
tig merged 3 commits into
tui-cs:developfrom
BDisp:menuitem-disabled-select-fix
Oct 31, 2022
Merged

Fixes #2137. Disabled menu item is selected on click.#2138
tig merged 3 commits into
tui-cs:developfrom
BDisp:menuitem-disabled-select-fix

Conversation

@BDisp

@BDisp BDisp commented Oct 26, 2022

Copy link
Copy Markdown
Collaborator

Fixes #2137 - The disabled menu item was always selected in a mouse click and should not.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tig
tig merged commit cccc358 into tui-cs:develop Oct 31, 2022
@BDisp
BDisp deleted the menuitem-disabled-select-fix branch October 31, 2022 16:22
This was referenced Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Strange behavior on a disabled menu item after clicked on it and moving the mouse. It stay selected and it shouldn't.

2 participants