Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add implementation for disconnect callback #8

Merged
merged 1 commit into from
Nov 10, 2017
Merged

Add implementation for disconnect callback #8

merged 1 commit into from
Nov 10, 2017

Conversation

cakesifu
Copy link
Contributor

@cakesifu cakesifu commented Nov 2, 2017

fixes #7

@cakesifu cakesifu mentioned this pull request Nov 2, 2017
Closed
@cakesifu
Copy link
Contributor Author

Do you think you could merge this in @tuanpmt ? It would be really great to have the onDisconnect feature.

@tuanpmt tuanpmt merged commit efb28eb into tuanpmt:master Nov 10, 2017
@tuanpmt
Copy link
Owner

tuanpmt commented Nov 10, 2017

i forgot it
Thanks.,

@cakesifu
Copy link
Contributor Author

Thank you for merging. Could we release this as 1.0.5?

@tuanpmt
Copy link
Owner

tuanpmt commented Nov 10, 2017

Done @cakesifu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

onDisconnect not defined
2 participants
@cakesifu @tuanpmt