-
-
Notifications
You must be signed in to change notification settings - Fork 0
Bump github.com/mark3labs/mcp-go from 0.25.0 to 0.35.0 with protocol negotiation, HTTP header, and race condition fixes #125
base: main
Are you sure you want to change the base?
Bump github.com/mark3labs/mcp-go from 0.25.0 to 0.35.0 with protocol negotiation, HTTP header, and race condition fixes #125
Conversation
…negotiation,_http_header,_and_race_condition_fixes_1754271707
WalkthroughThe dependency Changes
Sequence Diagram(s)Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Build & Verify Pipeline
go.mod
[error] 1-1: go.mod or go.sum is not tidy, run 'go mod tidy' to fix module dependencies.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: ci
🔇 Additional comments (1)
go.mod (1)
3-3:godirective should not include the patch version.
go 1.24.2is invalid syntax – the directive only acceptsmajor.minor. Usego 1.24(or the project’s target version).-go 1.24.2 +go 1.24
| require ( | ||
| github.com/mark3labs/mcp-go v0.25.0 | ||
| github.com/mark3labs/mcp-go v0.35.0 | ||
| github.com/spf13/viper v1.20.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Module is out-of-sync – run go mod tidy and commit the updated go.mod/go.sum.
The CI failure shows the module graph is not tidy. After bumping to github.com/mark3labs/mcp-go v0.35.0, transitive requirements (and potentially dropped deps) must be reconciled and go.sum regenerated.
Action:
go get github.com/mark3labs/mcp-go@v0.35.0
go mod tidyCommit both the updated go.mod and the new go.sum.
🤖 Prompt for AI Agents
In go.mod around lines 5 to 7, the module dependencies are out-of-sync after
updating github.com/mark3labs/mcp-go to v0.35.0. To fix this, run `go get
github.com/mark3labs/mcp-go@v0.35.0` followed by `go mod tidy` to reconcile
transitive dependencies and regenerate go.sum. Then commit the updated go.mod
and go.sum files to keep the module graph tidy and resolve the CI failure.
Bumps github.com/mark3labs/mcp-go from 0.25.0 to 0.35.0.
Release notes
Sourced from github.com/mark3labs/mcp-go's releases.
... (truncated)
Commits
3964d51feat: implement protocol version negotiation (#502)38ac77cGet rid of binary file. (#505)722d954enhc(server): allow adding multiple resource templates at once (#483)cc3f765Embed client capabilities into the Session (#491)5800c20Fix race condition in stdio.SendRequest with canceled context (#503)7c38b56Merge pull request #492 from pottekkat/fix/nil-pointer-dereference800e529fix: fix race conditionef2e795fix: proper handling95201f2fix: check if resp is nil on error for initialize methodsbaa7153Http headers (#480)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Completed by Agent
Fixes #75
Summary by CodeRabbit