-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pr Docs/2 honeytip swagger #5
Conversation
확인했습니다! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
재혁님 코드 확인했습니다!
제가 말씀드린 것 참고해주시고 반영해주시면 좋겠습니다.
제가 작업 완료한 질문해요 메인 화면의 명세서 코드를 참고하시면 좋을 것 같아 남겨드립니다! 참고자료
src/main/java/com/api/ttoklip/domain/honeytip/presentation/HoneytipController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/api/ttoklip/domain/honeytip/presentation/HoneytipController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/api/ttoklip/domain/honeytip/presentation/HoneytipController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/api/ttoklip/domain/honeytip/presentation/HoneytipController.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
재혁님 코드 확인했습니다.
저번 저의 의견 반영해주셔서 감사합니다!
package com.api.ttoklip.domain.honeytip.main.domain; | ||
|
||
public enum Category { | ||
HOUSEWORK, RECIPE, SAFE_LIVING, WELFARE_POLICY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enum을 더 의미있게 사용해보는 것은 어떨까요?
아래와 같이 사용하면 더 많은 정보들을 유연하게 활용할 수 있을 것 같습니다!
// 예시..
HOUSEWORK("집안일", 1),
RECIPE("요리", 2),
SAFE_LIVING("안전한 생활", 3),
WELFARE_POLICY("복지 정책", 4);
private final String name;
private final int code;
Category(String name, int code) {
this.name = name;
this.code = code;
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AllArgsConstructor
@getter
를 사용해도 좋을 것 같아요.
|
||
public HoneytipMainRes main() { | ||
return null; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
해당 메인의 기능이 제가 담당한 '질문해요'와 기능이 같은 것 같습니다. 그 중, 꿀팁의 메인 기능과 질문해요의 메인 기능을 합치는 ParenetMain과 같은 클래스를 만들어서 객체화하면 좋을 것 같은데 재혁님 의견이 궁금합니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
기능이 겹치는 부분은 합치는게 좋다고 생각합니다.
value = HoneytipResponseConstant.honeytipValue, | ||
description = "인기 꿀팁 Top 5와 카테고리별 3개가 한번에 응답으로 나갑니다." | ||
)))}) | ||
@GetMapping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
제 의견 반영해주셨네요 감사합니다
@Service | ||
@RequiredArgsConstructor | ||
public class HoneytipPostService { | ||
public Long register(HoneytipCreateReq request) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parameter에 final 키워드를 추가하여 불변성을 지키면 좋을 것 같습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
final 키워드 추가하였습니다.
Issue number and Link
이슈 번호 : #4
Summary
PR Type
Other Information
Common Type
branch