pr feat: 우리동네(함께해요, 소통해요) CRUD api 구현 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"api/v1"
Image => CommunityImage
Common에서 가져다 쓰기
Delete 제거
ImageResponse => CartImageResponse / ImageResponse => CommunityImageResponse
ImageRepository => CartImageRepository / ImageRepository => CommunityImageRepository
ImageService => CommunityImageService
Closed
5 tasks
CartPostController, CommunityPostController
총가격, 상품관련링크, 채팅링크, 참여인원, 거래희망장소
toychip
reviewed
Feb 4, 2024
| .title(request.getTitle()) | ||
| .build(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Cart에서 비활성화하는 로직을 @OverRide하면 좋을 것 같습니다.
지금 상속받은 BaseEntity에 있는 비활성화(sofr delete)를 진행하면 CartImage, CartComment는 비활성화가 진행되지 않기 때문입니다.
There was a problem hiding this comment.
forEach 사용하여 Cart와 연관된 엔티티들 비활성화하도록 코드 수정했어요~ 좋은 피드백 감사합니다!
@Override
public void deactivate() {
super.deactivate(); // BaseEntity에 정의되어 있는 메소드
this.cartImages.forEach(CartImage::deactivate);
this.reports.forEach(Report::deactivate);
this.cartComments.forEach(CartComment::deactivate);
this.itemUrls.forEach(ItemUrl::deactivate);
}
| /* -------------------------------------------- Soft Delete -------------------------------------------- */ | ||
| public void delete(final Long postId) { | ||
| Cart cart = findCart(postId); | ||
| cart.deactivate(); // 비활성화 |
There was a problem hiding this comment.
이부분 말씀드린겁니다!
Service에 있는 로직은 그대로 두되, cart에서 deactivate() 메서드를 오버라이드해서 Cart와 연관되어있는 Image, Comment등 같이 비활성화하면 좋을 것 같네요
src/main/java/com/api/ttoklip/domain/town/community/post/entity/Community.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Service | ||
| @RequiredArgsConstructor | ||
| public class CartPostService { |
There was a problem hiding this comment.
지금 카테고리별 조회, 단건 조회는 로직을 안만드신걸까요~?
There was a problem hiding this comment.
우리동네는 카테고리가 없어서 메인 페이지에서 '함께해요', '소통해요' 별로 조회 가능하게 만들겠습니다! 단건 조회 로직도 놓쳤었네요 ㅠ 추가할게요 !!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number and Link
Summary
공통 댓글 구현, 공통 신고 구현
질문해요 게시글 작성, 게시글 단건 조회, 댓글 생성, 댓글 수정, 댓글 삭제(soft delete, Report 때문)
PR Type
Other Information
'함께해요'와 '소통해요' 게시판의 겹치는 메인 기능들은 구현을 한 상태입니다.
'함께해요'의 추가 기능들은 이어서 진행하겠습니다.
Common Type
branch