-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pr Feat/40 newsletter delete admin #194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
뉴스레터 삭제 작업 고생 많으셨습니다
삭제 부분에서 권한 확인 부분 수정 부탁드려요.
또, 여기서 뉴스레터를 조회, 오늘의 뉴스레터 선정 할 때 삭제된 것을 제외하고 갖고와야할 것 같은데 지금 그부분은 추가되지 않은 것 같습니다.
src/main/java/com/api/ttoklip/domain/newsletter/post/service/NewsletterPostService.java
Outdated
Show resolved
Hide resolved
현재 사용자, 작성자 일치 여부 및 관리자 권한 확인
ErrorType
서비스 레이어의 checkEditAndManagerPermission 메서드에서 처리
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이제 뉴스레터 중에서 TodayNewsLetter 를 발급할 때나 다른 뉴스레터를 Get요청할 때 isDeleted 필드로 확인해야할 것 같습니다~
softDeleted 처리했는데 보이면 안되니까요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오늘의 뉴스레터 뽑는 스케줄러에서 제외되도록 제가 수정했습니다~
참고해보십쇼
Issue number and Link
Summary
관리자의 뉴스레터 삭제 기능 구현
PR Type