Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pr Feat/40 newsletter delete admin #194

Merged
merged 8 commits into from
Sep 2, 2024
Merged

pr Feat/40 newsletter delete admin #194

merged 8 commits into from
Sep 2, 2024

Conversation

why-only-english
Copy link
Contributor

@why-only-english why-only-english commented Aug 28, 2024 •
edited
Loading

Issue number and Link

Summary

관리자의 뉴스레터 삭제 기능 구현

PR Type

  • Feature
  • Bugfix
  • Refactoring
  • Documentation
  • Other

@why-only-english why-only-english added ✨ Feature 새로운 기능 추가 🔀 PullRequest Branch 합병 문종근 labels Aug 28, 2024
@why-only-english why-only-english self-assigned this Aug 28, 2024
@why-only-english why-only-english linked an issue Aug 28, 2024 that may be closed by this pull request
feat: 뉴스레터 삭제 #189
Closed
2 tasks
toychip
toychip requested changes Aug 28, 2024
View reviewed changes
Copy link
Member

@toychip toychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

뉴스레터 삭제 작업 고생 많으셨습니다
삭제 부분에서 권한 확인 부분 수정 부탁드려요.
또, 여기서 뉴스레터를 조회, 오늘의 뉴스레터 선정 할 때 삭제된 것을 제외하고 갖고와야할 것 같은데 지금 그부분은 추가되지 않은 것 같습니다.

src/main/java/com/api/ttoklip/domain/newsletter/post/service/NewsletterPostService.java Outdated Show resolved Hide resolved
toychip
toychip requested changes Sep 1, 2024
View reviewed changes
Copy link
Member

@toychip toychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이제 뉴스레터 중에서 TodayNewsLetter 를 발급할 때나 다른 뉴스레터를 Get요청할 때 isDeleted 필드로 확인해야할 것 같습니다~
softDeleted 처리했는데 보이면 안되니까요!

toychip
toychip approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@toychip toychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오늘의 뉴스레터 뽑는 스케줄러에서 제외되도록 제가 수정했습니다~
참고해보십쇼

@why-only-english why-only-english merged commit fbd6c33 into main Sep 2, 2024
@toychip toychip deleted the Feat/40-newsletter-delete-admin branch October 17, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toychip toychip toychip approved these changes

Assignees

@why-only-english why-only-english

Labels
✨ Feature 새로운 기능 추가 🔀 PullRequest Branch 합병 문종근
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: 뉴스레터 삭제
2 participants
@why-only-english @toychip