fix: 잘못된 newsletter getActivatedNewsletterFromComments() query 수정 (#206)

ttoklip · Sep 5, 2024 · 253f7d7 · 253f7d7
1 parent 381c918
commit 253f7d7
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/...a/com/api/ttoklip/domain/newsletter/post/repository/NewsletterQueryDslRepositoryImpl.java b/...a/com/api/ttoklip/domain/newsletter/post/repository/NewsletterQueryDslRepositoryImpl.java
@@ -58,6 +58,10 @@ private BooleanExpression getActivatedNewsletter() {
         return newsletter.deleted.isFalse();
     }
 
+    private BooleanExpression getActivatedNewsletterFromComments() {
+        return newsletterComment.newsletter.deleted.isFalse();
+    }
+
     @Override
     public Newsletter findByIdFetchJoin(Long newsletterPostId) {
         Newsletter findNewsletter = jpaQueryFactory
@@ -80,10 +84,10 @@ public List<NewsletterComment> findActiveCommentsByNewsletterId(Long newsletterI
         return jpaQueryFactory
                 .selectFrom(newsletterComment)
                 .distinct()
-                .leftJoin(newsletter.member, member).fetchJoin()
+                .leftJoin(newsletterComment.member, member).fetchJoin()
                 .where(
                         matchNewsletterId(newsletterId),
-                        getActivatedNewsletter()
+                        getActivatedNewsletterFromComments()
                 )
                 .orderBy(
                         newsletterComment.parent.id.asc().nullsFirst(),
@@ -92,6 +96,7 @@ public List<NewsletterComment> findActiveCommentsByNewsletterId(Long newsletterI
                 .fetch();
     }
 
+
     private BooleanExpression matchNewsletterId(final Long newsletterId) {
         return newsletterComment.newsletter.id.eq(newsletterId);
     }