-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Ntfy.sh notification support #161
Conversation
… authentication with username/password or token
…kerfile and fixed a bug in the base64 encoding which caused newlines when using longer passwords
Thank you for your contribution. Recently, I have been engrossed in the game "Black Myth: Wukong". Now that I have completed it, I just saw this PR and apologize for the delay. Ntfy.sh is an excellent push notification system. The existing environment variables Ntfy.sh supports GET requests, as detailed in the documentation. If the environment variable Ntfy.sh offers a wide range of features, and I do not believe it is wise to provide an environment variable for each feature. The PR added 10 new environment variables, and in the future, we might need to add environment variables for setting |
My current plan is to add corresponding For Ntfy.sh, you can set Additionally, I will add placeholders for these environment variables, such as This approach allows for more functionality with fewer environment variables and avoids continuous adaptation to specific tools, similar to the I will add the above features as soon as possible. |
Thank you for your reply, that indeed sounds like a better option. If I can help in any way please let me know. I'll close this PR |
Released v1.21.0 |
Ntfy,sh is a selfhostable notification service. As I use ntfy.sh for notifications about my homelab, I missed the integration in vaultwarden-backup as that only supports PING and MAIL.
This PR will add Ntfy,sh support, it supports 3 different authentication modes: No authentication, username + password and token based authentication.
Also the priority of the notifications are configurable, so that a backup failure results in a more urgent notification on the subscribed clients.