opt: code

tsundata · Apr 12, 2021 · 1fed331 · 1fed331
1 parent 7ce7d9d
commit 1fed331
Show file tree

Hide file tree

Showing 5 changed files with 39 additions and 42 deletions.
diff --git a/internal/app/cron/agent/github.go b/internal/app/cron/agent/github.go
@@ -26,26 +26,26 @@ func FetchGithubStarred(b *rulebot.RuleBot) []result.Result {
 	if err != nil {
 		return []result.Result{result.ErrorResult(err)}
 	}
-	if *user.Login != "" {
-		repos, err := client.GetStarred(*user.Login)
-		if err != nil {
-			return []result.Result{result.ErrorResult(err)}
-		}
-		var r []result.Result
-		for _, item := range *repos {
-			r = append(r, result.Result{
-				ID:   utils.SHA1(*item.HTMLURL),
-				Kind: result.Repos,
-				Content: map[string]string{
-					"name":  *item.FullName,
-					"owner": *item.Owner.Login,
-					"repo":  *item.Name,
-					"url":   *item.HTMLURL,
-				},
-			})
-		}
-		return r
+	if *user.Login == "" {
+		return []result.Result{result.EmptyResult()}
 	}
 
-	return []result.Result{result.EmptyResult()}
+	repos, err := client.GetStarred(*user.Login)
+	if err != nil {
+		return []result.Result{result.ErrorResult(err)}
+	}
+	var r []result.Result
+	for _, item := range *repos {
+		r = append(r, result.Result{
+			ID:   utils.SHA1(*item.HTMLURL),
+			Kind: result.Repos,
+			Content: map[string]string{
+				"name":  *item.FullName,
+				"owner": *item.Owner.Login,
+				"repo":  *item.Name,
+				"url":   *item.HTMLURL,
+			},
+		})
+	}
+	return r
 }
diff --git a/internal/app/cron/agent/pocket.go b/internal/app/cron/agent/pocket.go
@@ -41,21 +41,20 @@ func FetchPocket(b *rulebot.RuleBot) []result.Result {
 	if err != nil {
 		return []result.Result{result.ErrorResult(err)}
 	}
-
-	if resp.Status > 0 {
-		var r []result.Result
-		for _, item := range resp.List {
-			r = append(r, result.Result{
-				ID:   utils.SHA1(item.ResolvedUrl),
-				Kind: result.Url,
-				Content: map[string]string{
-					"title": item.ResolvedTitle,
-					"url":   item.ResolvedUrl,
-				},
-			})
-		}
-		return r
+	if resp.Status == 0 {
+		return []result.Result{result.EmptyResult()}
 	}
 
-	return []result.Result{result.EmptyResult()}
+	var r []result.Result
+	for _, item := range resp.List {
+		r = append(r, result.Result{
+			ID:   utils.SHA1(item.ResolvedUrl),
+			Kind: result.Url,
+			Content: map[string]string{
+				"title": item.ResolvedTitle,
+				"url":   item.ResolvedUrl,
+			},
+		})
+	}
+	return r
 }
diff --git a/internal/app/gateway/controllers/controllers.go b/internal/app/gateway/controllers/controllers.go
@@ -8,7 +8,6 @@ import (
 )
 
 func CreateInitControllersFn(gc *GatewayController) func(router fiber.Router) {
-
 	requestHandler := func(router fiber.Router) {
 		defer func() {
 			if err := recover(); err != nil {

diff --git a/internal/app/worker/tasks/workflow.go b/internal/app/worker/tasks/workflow.go
@@ -51,9 +51,8 @@ func (t *WorkflowTask) Run(data string) (bool, error) {
 		if err != nil {
 			return false, err
 		}
+		return true, nil
 	default:
 		return false, errors.New("error type")
 	}
-
-	return true, nil
 }
diff --git a/internal/app/workflow/service/workflow.go b/internal/app/workflow/service/workflow.go
@@ -52,9 +52,9 @@ func (s *Workflow) SyntaxCheck(_ context.Context, payload *pb.WorkflowRequest) (
 		}
 
 		return &pb.StateReply{State: true}, nil
+	default:
+		return &pb.StateReply{State: false}, nil
 	}
-
-	return &pb.StateReply{State: false}, nil
 }
 
 func (s *Workflow) RunAction(_ context.Context, payload *pb.WorkflowRequest) (*pb.WorkflowReply, error) {
@@ -235,11 +235,11 @@ func (s *Workflow) CreateTrigger(_ context.Context, payload *pb.TriggerRequest)
 				return nil, err
 			}
 		}
+
+		return &pb.StateReply{State: true}, nil
 	default:
 		return &pb.StateReply{State: false}, nil
 	}
-
-	return &pb.StateReply{State: true}, nil
 }
 
 func (s *Workflow) DeleteTrigger(_ context.Context, payload *pb.TriggerRequest) (*pb.StateReply, error) {