rpc: ignore offline/unassigned regions during cache warmup #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When warming up the cache, ignore regions that are offline/unassigned. They could exist for many reasons: - parent region after a split, until daughter regions are compacted - regions that are merged together, until compaction happens - region moving due to HBase LoadBalancer, RegionServer shutting down or manually - etc It's not critical if we are missing a few regions in the cache during warmup. The most important thing is for the warmup to be fast and to fill in with as many regions as possible. Other regions will be fetched later as needed.
dethi
force-pushed
the
fix-meta-warmup
branch
from
fe79802
to
a245718
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When warming up the cache, ignore regions that are offline/unassigned. They could exist for many reasons:
It's not critical if we are missing a few regions in the cache during warmup. The most important thing is for the warmup to be fast and to fill in with as many regions as possible. Other regions will be fetched later as needed.