Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hrpc: allow table creation with table attributes #234

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

dethi
Copy link
Collaborator

@dethi dethi commented Sep 4, 2023

Closes #161

@dethi dethi changed the title hrcp: allow table creation with table attributes hrpc: allow table creation with table attributes Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.15% ⚠️

Comparison is base (701886e) 70.30% compared to head (14a9988) 70.16%.

❗ Current head 14a9988 differs from pull request most recent head 21191da. Consider uploading reports for the commit 21191da to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
- Coverage   70.30%   70.16%   -0.15%     
==========================================
  Files          27       27              
  Lines        3718     3730      +12     
==========================================
+ Hits         2614     2617       +3     
- Misses        989      995       +6     
- Partials      115      118       +3     
Files Changed Coverage Δ
hrpc/create.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dethi dethi merged commit f750f62 into master Sep 21, 2023
2 checks passed
@dethi dethi deleted the table-attributes branch September 21, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CreateTable should allow table attributes
2 participants