Merge pull request #174 from tsugumi-sys/feature/remove-session-local…

…-import techdebt: remove sessionlocal import
tsugumi-sys · Jul 7, 2024 · 3baf777 · 3baf777
2 parents 9b02932 + f18f856
commit 3baf777
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 14 deletions.
diff --git a/tests/nasdaqapi/test_cli.py b/tests/nasdaqapi/test_cli.py
@@ -3,7 +3,6 @@
 import pytest
 from click.testing import CliRunner
 
-from conftest import SessionLocal  # noqa: F401
 from stocklake.exceptions import StockLakeException
 from stocklake.nasdaqapi import cli
 from stocklake.nasdaqapi.constants import Exchange
@@ -43,7 +42,7 @@ def test_nasdaqapi(
     store_type,
     MockNasdaqAPIServer,  # noqa: F811
     monkeypatch,
-    SessionLocal,  # noqa: F811
+    SessionLocal,
 ):
     monkeypatch.setenv("_STOCKLAKE_ENVIRONMENT", "test")
     monkeypatch.setenv("STOCKLAKE_POLYGON_API_KEY", "dummy_key")

diff --git a/tests/nasdaqapi/test_pipeline.py b/tests/nasdaqapi/test_pipeline.py
@@ -2,7 +2,6 @@
 
 import pytest
 
-from conftest import SessionLocal  # noqa: F401
 from stocklake.exceptions import StockLakeException
 from stocklake.nasdaqapi.constants import Exchange
 from stocklake.nasdaqapi.pipeline import NASDAQSymbolsPipeline
@@ -54,7 +53,7 @@ def test_run_with_local_artifact(tmpdir, MockNasdaqAPIServer):  # noqa: F811
 def test_run_each_symbols_with_postgresql(
     exchange,
     tmpdir,
-    SessionLocal,  # noqa: F811,
+    SessionLocal,
     MockNasdaqAPIServer,  # noqa: F811
 ):
     pipeline = NASDAQSymbolsPipeline(

diff --git a/tests/nasdaqapi/test_stores.py b/tests/nasdaqapi/test_stores.py
@@ -3,7 +3,6 @@
 
 import pytest
 
-from conftest import SessionLocal  # noqa: F401
 from stocklake.nasdaqapi.constants import Exchange
 from stocklake.nasdaqapi.entities import NasdaqApiDataCreate
 from stocklake.nasdaqapi.stores import (

diff --git a/tests/polygonapi/test_cli.py b/tests/polygonapi/test_cli.py
@@ -1,7 +1,6 @@
 import pytest
 from click.testing import CliRunner
 
-from conftest import SessionLocal  # noqa: F401
 from stocklake.exceptions import StockLakeException
 from stocklake.polygonapi import cli
 from stocklake.polygonapi.constants import PolygonAPIType
@@ -56,7 +55,7 @@ def test_polygonapi_stock_financials_vx(
     store_type,
     MockPolygonAPIServer,  # noqa: F811
     monkeypatch,
-    SessionLocal,  # noqa: F811
+    SessionLocal,
 ):
     monkeypatch.setenv("_STOCKLAKE_ENVIRONMENT", "test")
     monkeypatch.setenv("STOCKLAKE_POLYGON_API_KEY", "dummy_key")

diff --git a/tests/polygonapi/test_pipeline.py b/tests/polygonapi/test_pipeline.py
@@ -2,7 +2,6 @@
 
 import pytest
 
-from conftest import SessionLocal  # noqa: F401
 from stocklake.exceptions import StockLakeException
 from stocklake.polygonapi.pipeline import PolygonFinancialsDataPipeline
 from stocklake.polygonapi.stores import SAVE_ARTIFACTS_DIR
@@ -36,7 +35,7 @@ def test_run_with_local_artifact(MockPolygonAPIServer, monkeypatch):  # noqa: F8
 def test_run_with_postgresql(
     MockPolygonAPIServer,  # noqa: F811
     monkeypatch,
-    SessionLocal,  # noqa: F811
+    SessionLocal,
 ):
     monkeypatch.setenv("STOCKLAKE_POLYGON_API_KEY", "dummy_key")
     pipeline = PolygonFinancialsDataPipeline(

diff --git a/tests/polygonapi/test_stores.py b/tests/polygonapi/test_stores.py
@@ -2,7 +2,6 @@
 
 import pytest
 
-from conftest import SessionLocal  # noqa: F401
 from stocklake.environment_variables import STOCKLAKE_POLYGON_API_KEY
 from stocklake.polygonapi import entities
 from stocklake.polygonapi.data_loader import PolygonFinancialsDataLoader
@@ -38,7 +37,7 @@ def test_polygon_financials_store_local_artifact(
 
 
 def test_polygon_financials_store_postgresql(
-    SessionLocal,  # noqa: F811
+    SessionLocal,
     polygon_financials_data,
 ):
     store = PolygonFinancialsDataStore(SessionLocal)
@@ -50,7 +49,7 @@ def test_polygon_financials_store_postgresql(
 
 def test_PolygonFinancialsDataSQLAlchemyStore_create(
     polygon_financials_data,
-    SessionLocal,  # noqa: F811
+    SessionLocal,
 ):
     data_length = len(polygon_financials_data)
     with SessionLocal() as session, session.begin():
@@ -72,7 +71,7 @@ def test_PolygonFinancialsDataSQLAlchemyStore_create(
 
 def test_PolygonFinancialsDataSQLAlchemyStore_delete(
     polygon_financials_data,
-    SessionLocal,  # noqa: F811
+    SessionLocal,
 ):
     data_length = len(polygon_financials_data)
     with SessionLocal() as session, session.begin():

diff --git a/tests/stores/db/test_utils.py b/tests/stores/db/test_utils.py
@@ -1,7 +1,6 @@
 import pytest
 from click.testing import CliRunner
 
-from conftest import SessionLocal  # noqa: F401
 from stocklake.core.stdout import PrettyStdoutPrint
 from stocklake.stores.db import cli
 from stocklake.stores.db.database import database_url