Merged
Conversation
corrected "decode" functionality to decode both cat and numeric variables
Owner
|
Thanks @antndlcrx! The checks are failing because it can't find sdmetrics (the requirement also needs to be in the github actions workflow file, so the test server is set up right). But looking at your code, do we actually need the import in sygnet itself? Seems like none of the changes above actually use the imported QualityReport function? |
Collaborator
Author
|
No, we do not need sdmetrics for the code here, I included it mistakenly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the main change is the model.sample(decode=True) code to enable decoding of both numeric and categorical features