Fix jsonNumber bug #20
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks @tsoding for your awesome youtube videos, really enjoyed it and learnt quite a few things from you.
And here goes the story:
I added a little helper function for my ghci convenience:
And when I ran your original code, I found something interesting:
Obviously it's because of our most intelligent
read
function ¯\(ツ)/¯ .After the PR changes it now becomes:
Sorry for the multiple commits to fix nits and make CI happy, feel free to squash merge.
Comments and suggestions welcome :)