Documentation and fix parsing Double #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rexim
requested changes
Apr 23, 2020
|
The current test in my local does not parse 4e-6 correctly. I do get an ERROR executing main. Does it work for you @rexim ? |
|
@dan323 ah, I see what you mean! Sorry, didn't read your description careful enough. :D Looks good to me! Thanks for fixing this! |
rexim
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I tested it in my computer, it ended in error because of rounding mistakes building 4e-6. In this PR I try to minimize those.
Since I am new to Haskell, I needed to document the file to be more aware of what the different functions do; so I decided to push that documentation too.