Skip to content

Rewrite parseIf #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

lulucca12
Copy link

Used mfilter :: MonadPlus m => (a -> Bool) -> m a -> m a as Maybe has an automatic instance of MonadPlus derived from the instance of Alternative.

@rexim
Copy link
Member

rexim commented Nov 25, 2019

@lulucca12 hey! Thanks for the Pull Request, unfortunately it doesn't add any new functionality to the parser. Please check https://github.com/tsoding/haskell-json#contribution-notes for more information.

@rexim rexim closed this Nov 25, 2019
@lulucca12
Copy link
Author

@rexim I don't see the meaning of this. Isn't what I did the exact same thing as #4 did? Rewrite the implemetation without adding fuctionality and it got merged?
Besides isn't that what managers are for? I remember one time when Linus Torvalds said about his bad actions at the Linux maling list as he invented git the way he did for being able to pass his work to others.
So why don't just elect a manager or be more liberal about it and enable merging without supervision, just reviewing?

@rexim
Copy link
Member

rexim commented Nov 26, 2019

@lulucca12 #4 was submitted before e886bfb

@lulucca12
Copy link
Author

@rexim does that mean that you changed the rules in the middle of the game?
Fine, thats why it is open source ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants