Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include esbuild as devDependency #81

Merged
merged 1 commit into from
Sep 28, 2024
Merged

fix: include esbuild as devDependency #81

merged 1 commit into from
Sep 28, 2024

Conversation

abiriadev
Copy link
Contributor

@abiriadev abiriadev commented Jul 24, 2024

First of all, thanks for the awesome project!

Problem

The build script calles esbuild:

"build": "tsc & esbuild --bundle --target=esnext --platform=neutral --outfile=index.js src/index.ts & wait",

(ref: c6b3a83)

However, ESBuild is missing from the devDependencies in the package.json file:

"devDependencies": {
"@cloudflare/workers-types": "^4.20240208.0",
"@edge-runtime/vm": "^3.2.0",
"typescript": "^5.3.3",
"vitest": "^1.3.1"
}

Thus, the npm run build script fails:

Changes

This PR just adds missing esbuild to the devDependencies in the package.json file, to build the project successfully. (in CI server in my case)

@tsndr tsndr merged commit b46db60 into tsndr:main Sep 28, 2024
@tsndr
Copy link
Owner

tsndr commented Sep 28, 2024

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants