Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor low-level column access #422

Merged
merged 1 commit into from
Dec 4, 2022
Merged

Refactor low-level column access #422

merged 1 commit into from
Dec 4, 2022

Conversation

molpopgen
Copy link
Member

Macros to access table columns from the C API are getting cluttered.
Further, using macros may be causing unnecessary code bloat.

This PR:

  • Replaces macros with generic functions.
  • Separates common elements of table access to reduce the number of monomorphized functions.

@molpopgen
style: replace column access macro with generic fn
489630c 
This change improves readability and declutters
some internal details.
@molpopgen molpopgen marked this pull request as ready for review December 4, 2022 17:18
@molpopgen molpopgen merged commit 1a80144 into main Dec 4, 2022
@molpopgen molpopgen deleted the macro_clutter branch December 4, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@molpopgen