Update flags API. #227
Merged
Update flags API. #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molpopgen
force-pushed
the
streamline_flags
branch
6 times, most recently
from
26897ed to
ccf387a
Compare
* Add RawFlags as typedef for tsk_flags_t * Add From<RawFlags> for flags types. The implementation will remove invalid bits that are set, except for NodeFlags/IndividualFlags which allow client-defined flags. * Flags types are now repr(transparent) * Functions taking flags are now generic over Into<flags type> Breaking changes: * Added NodeFlags and InidividualFlags as first-class types. Functions previously returning, e.g, &[tsk_flags_t] now return &[NodeFlags], etc.. Due to repr(transparent), these return values have the same ABI. Closes #226
molpopgen
force-pushed
the
streamline_flags
branch
from
ccf387a to
1b224ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements several refinements to the handling of "flags":
implblock for all flags types with a single fn,validate, that checks for invalid flags.Breaking change:
Node and Individual flags replace tsk_flags_t in the public API, which changes the return value type of some fns. In most cases, this will be transparent.