Improve tests for table types #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molpopgen
force-pushed
the
add_tests_for_strong_ID_types
branch
from
9fa7803 to
504fa6f
Compare
molpopgen
changed the title
collections": * Add generic metadata fixture. * Add missing Iterator implementations for IndividualTableIterator and IndividualTableRefIterator. * TableCollection::add_migration_* now return Result<MigrationId, TskitError>. * Fix bug where MigrationTable::node and MigrationTable::source were accessing the wrong C arrays.
molpopgen
force-pushed
the
add_tests_for_strong_ID_types
branch
from
a8f4f33 to
345b164
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In light of the new row ID types introduced recently (see #128), this PR adds a lot of tests to the various "tables" files.
These tests have:
Removing/reducing redundant tests can be handled in a follow-up PR. That follow up can maybe also add more of what we need, which is detailed checks of all the various Option inputs, etc., and how they affect table row equality comparisons, etc..