Skip to content

Warn zero #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Warn zero #685

merged 2 commits into from
Jun 28, 2022

Conversation

hyanwong
Copy link
Member

@hyanwong hyanwong commented Jun 24, 2022

Fixes #683. Also includes some changes to make the VCF reading code a little more picky.

@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #685 (0e3305c) into main (2a06def) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #685   +/-   ##
=======================================
  Coverage   93.10%   93.11%           
=======================================
  Files          17       17           
  Lines        5151     5153    +2     
  Branches      958      959    +1     
=======================================
+ Hits         4796     4798    +2     
  Misses        235      235           
  Partials      120      120           
Flag Coverage Δ
C 93.11% <100.00%> (+<0.01%) ⬆️
python 96.32% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tsinfer/inference.py 98.57% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a06def...0e3305c. Read the comment docs.

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 87f7b54 into tskit-dev:main Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raise warning when zero inference sites provided.
2 participants