Set time_units

[hyanwong]

No tests yet, draft to se if this is the right simple approach.

[codecov]

Codecov Report

Merging #680 (9587d39) into main (34bd064) will decrease coverage by 3.21%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #680      +/-   ##
==========================================
- Coverage   96.32%   93.10%   -3.22%     
==========================================
  Files          12       17       +5     
  Lines        3507     5149    +1642     
  Branches      666      957     +291     
==========================================
+ Hits         3378     4794    +1416     
- Misses         96      235     +139     
- Partials       33      120      +87     

Flag	Coverage Δ
C	93.10% <100.00%> (?)
python	96.32% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
tsinfer/inference.py	98.57% <100.00%> (+<0.01%)	⬆️
lib/tree_sequence_builder.c	82.82% <0.00%> (ø)
lib/object_heap.c	67.04% <0.00%> (ø)
lib/ancestor_builder.c	87.57% <0.00%> (ø)
lib/ancestor_matcher.c	90.12% <0.00%> (ø)
lib/err.c	100.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34bd064...9587d39. Read the comment docs.

[jeromekelleher]

LGTM. Does the time_units of the ancestors tree sequence get inherited by the final tree sequence?

[hyanwong]

LGTM.

Great

Does the time_units of the ancestors tree sequence get inherited by the final tree sequence?

I will check in the tests. About to write now. Got held up by writing the workbook!

[hyanwong]

Tests done.

To avoid setting the time units on separate code paths, I changed get_ancestors_tree_sequence to return the tables (rather than converting the tables to a ts on the last line), then the conversion can happen in store_output. That seemed sensible anyway.

[jeromekelleher]

LGTM, just another test and update the changelog please.