Skip to content

Test suite to use new msprime calling convention #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 7, 2022

Conversation

hyanwong
Copy link
Member

Ideally we should switch to the new msprime for testing, since it has discrete genome coords, individuals, metadata, etc. This switches the tree sequences used for testing to new format versions

@hyanwong
Copy link
Member Author

Oh damn, requires tskit 0.4. Will wait, I guess.

@hyanwong
Copy link
Member Author

hyanwong commented Mar 5, 2022

Lots of this seems to be "TypeError: 'PopulationTable' object does not support item assignment". Is this post-tskit 0.4.0?

@codecov
Copy link

codecov bot commented Mar 5, 2022

Codecov Report

Merging #614 (0e2b25c) into main (b6662b3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #614   +/-   ##
=======================================
  Coverage   93.08%   93.08%           
=======================================
  Files          17       17           
  Lines        5136     5136           
  Branches      954      954           
=======================================
  Hits         4781     4781           
  Misses        235      235           
  Partials      120      120           
Flag Coverage Δ
C 93.08% <ø> (ø)
python 96.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6662b3...0e2b25c. Read the comment docs.

@hyanwong
Copy link
Member Author

hyanwong commented Mar 5, 2022

I think this is entirely uncontroversial, and gets CI working again, so other PRs can start going through. Looks like the requirements conflict needs a tiny tweak before merging, so that we are using tskit 0.4.1, but after that it presumably can be merged. Do you think you might have time to do that @benjeffery or @jeromekelleher ? I'm not sure how to do it.

@jeromekelleher
Copy link
Member

I'll take a look now.

@hyanwong
Copy link
Member Author

hyanwong commented Mar 7, 2022

Thanks Jerome. That's much appreciated.

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should do it, thanks for sorting this out @hyanwong!

@hyanwong
Copy link
Member Author

hyanwong commented Mar 7, 2022

Hooray, thanks @jeromekelleher. Merge away

@jeromekelleher
Copy link
Member

Looks like a random number problem on Windows, can you take a look please?

@hyanwong hyanwong force-pushed the new-msprime branch 2 times, most recently from fc7bf69 to 97b27ee Compare March 7, 2022 13:20
@mergify mergify bot merged commit a34f65a into tskit-dev:main Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants