-
Notifications
You must be signed in to change notification settings - Fork 16
Test suite to use new msprime calling convention #614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Oh damn, requires tskit 0.4. Will wait, I guess. |
cb8141f
to
9bf637d
Compare
9bf637d
to
0f0516c
Compare
Lots of this seems to be "TypeError: 'PopulationTable' object does not support item assignment". Is this post-tskit 0.4.0? |
Codecov Report
@@ Coverage Diff @@
## main #614 +/- ##
=======================================
Coverage 93.08% 93.08%
=======================================
Files 17 17
Lines 5136 5136
Branches 954 954
=======================================
Hits 4781 4781
Misses 235 235
Partials 120 120
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
I think this is entirely uncontroversial, and gets CI working again, so other PRs can start going through. Looks like the requirements conflict needs a tiny tweak before merging, so that we are using tskit 0.4.1, but after that it presumably can be merged. Do you think you might have time to do that @benjeffery or @jeromekelleher ? I'm not sure how to do it. |
I'll take a look now. |
Thanks Jerome. That's much appreciated. |
23e67d4
to
d6ef7cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should do it, thanks for sorting this out @hyanwong!
Hooray, thanks @jeromekelleher. Merge away |
Looks like a random number problem on Windows, can you take a look please? |
fc7bf69
to
97b27ee
Compare
Ideally we should switch to the new msprime for testing, since it has discrete genome coords, individuals, metadata, etc. This switches the tree sequences used for testing to new format versions