Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix references to "flat" priors in docs #426

Merged
merged 4 commits into from
Jul 27, 2024

Conversation

nspope
Copy link
Contributor

@nspope nspope commented Jul 27, 2024

as we actually do use a "prior" (really, regularisation) on root node ages.

Fix references to "flat" priors in docs
@hyanwong
Copy link
Member

But we do use a flat prior on non-root ages, right?

@hyanwong
Copy link
Member

I think it would be good to keep the idea that the prior on non-roots is essentially flat (after all, these are most of the nodes we are trying to date: the roots are an exception)

@nspope
Copy link
Contributor Author

nspope commented Jul 27, 2024

What we're doing is using regularisation on the roots-- fit by EM. If viewed as a prior (ignoring the EM) this induces a distribution on the internal nodes, too. I agree, it's much less strong than using informative priors on every node. But I think it's good to be clear about what we're doing here, until we write up the algorithm.

@hyanwong hyanwong merged commit c4c9eac into tskit-dev:main Jul 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants