Skip to content

Conversation

@andrewkern
Copy link
Member

editing the warning introduced in #1955 for clarity as to what the issue is

@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #1962 (7d2baa2) into main (30678bb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1962   +/-   ##
=======================================
  Coverage   91.17%   91.17%           
=======================================
  Files          20       20           
  Lines       10677    10677           
  Branches     2209     2209           
=======================================
  Hits         9735     9735           
  Misses        516      516           
  Partials      426      426           
Flag Coverage Δ
C 91.17% <ø> (ø)
python 98.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
msprime/ancestry.py 99.10% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30678bb...7d2baa2. Read the comment docs.

@petrelharp
Copy link
Contributor

I'm confused - what does it mean if you run it back to a high initial frequency, if not a "sweep from standing genetic variation"?

@andrewkern
Copy link
Member Author

that you aren't conditioning on allele frequency dynamics back in time, past when the allele hit the final frequency

@molpopgen
Copy link
Member

I'm confused - what does it mean if you run it back to a high initial frequency, if not a "sweep from standing genetic variation"?

It means that you've taken a structured coalescent back to some point determined by "initial frequency" and then suddenly unstructure it (b/c there's no merged API that means "finish it w/a neutral trajectory").

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit ddb25b6 into tskit-dev:main Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants