-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: l10n_currencies
v1.0.0
#288
Conversation
π WalkthroughWalkthroughThis pull request marks the first stable release of the Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? πͺ§ TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
π Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
π Files selected for processing (4)
packages/l10n_currencies/CHANGELOG.md
(1 hunks)packages/l10n_currencies/README.md
(3 hunks)packages/l10n_currencies/example/lib/main.dart
(1 hunks)packages/l10n_currencies/pubspec.yaml
(1 hunks)
π§° Additional context used
πͺ Markdownlint (0.37.0)
packages/l10n_currencies/CHANGELOG.md
1-1: null
First line in a file should be a top-level heading
(MD041, first-line-heading, first-line-h1)
πͺ LanguageTool
packages/l10n_currencies/README.md
[duplication] ~17-~17: Possible typo: you repeated a word.
Context: ...upported out of the box. - Three-letter ISO ISO 4217 Alpha code lookup. - Fallback loca...
(ENGLISH_WORD_REPEAT_RULE)
π Additional comments (3)
packages/l10n_currencies/pubspec.yaml (1)
1-1
: LGTM! Version bump to 1.0.0 is appropriate.The version bump to 1.0.0 is well justified as this marks the first stable release with improved documentation and examples.
packages/l10n_currencies/example/lib/main.dart (1)
10-10
: LGTM! Improved comment formatting.The added space before the code block improves readability.
packages/l10n_currencies/README.md (1)
19-19
: LGTM! New feature documentation added.The addition of custom translations feature documentation is valuable for users.
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #288 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 30 2 -28
Lines 482 216 -266
==========================================
- Hits 482 216 -266
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
π Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
π Files selected for processing (1)
packages/l10n_currencies/README.md
(3 hunks)
π Additional comments (4)
packages/l10n_currencies/README.md (4)
12-12
: LGTM!Clear recommendation for package usage in Dart-only context.
17-17
: LGTM - Redundancy fixed!The redundant "ISO" has been removed, improving documentation clarity.
47-47
: LGTM!Clear and well-formatted comment in the example.
76-76
: LGTM!Excellent addition of package size information with clear explanation of its benefits.
Description
Type of Change
Checks
Please look at the following checklist to ensure that your PR can be accepted quickly:
Summary by CodeRabbit
New Features
Documentation
Release