Cocoa port

[Frityet]

this PR will eventually have a full port to Cocoa, the native GUI library for MacOS.

[Frityet]

@AndroGR I need some help adding Cocoa to the CMakeLists.txt, I am not used to cmake

[tseli0s]

Hello,
These days I'm not getting on my computer due to school and being sick. So while I'll be able to see your progress, I can't (temporarily) make any code commits or test anything out.

In the meantime, if you have any questions, feel free to make them; I'm able to help at any moment.

[Frityet]

if you have any questions, feel free to make them

How do I add a new target to the cmake? in my testing this seems to completley not work as when I try to build it only goes to GTK4

[tseli0s]

You seem to have confused what previously written code (Specifically the WIN32_TARGET option) does, and that's why. Try using the Gtk3 or libadwaita parts instead. Otherwise I'll take care of it while you write the actual backend.

ED: The WIN32_TARGET option is used to build a Windows library from Linux, it's just for Wine testing.

[Frityet]

You seem to have confused what previously written code (Specifically the WIN32_TARGET option) does, and that's why. Try using the Gtk3 or libadwaita parts instead. Otherwise I'll take care of it while you write the actual backend.

ED: The WIN32_TARGET option is used to build a Windows library from Linux, it's just for Wine testing.

Oh okay, thank you!

[tseli0s]

Another thing I've noticed, you seem to mix Objective C and C code in one file, and then to the actual library. This is a horrible decision: It may not work between compilers due to different ABIs, may fail to build in the first place or may cause undefined behavior due to type mismatches.

If possible, create a C file where you call the functions from another, independently built library. So something like this could do:

// backend/cocoa/nvdialog_file_dialog.c

void nvd_get_file_location_cocoa(...) {
    // FFI call, from your Obj-C code
    nvd_get_file_location_cocoa_REAL(...)
}

And implement nvd_get_file_location_cocoa_REAL in another file, which you're going to link as a library.

If all that sounds hard, you can try writing a Makefile to use temporarily. You can also use extern "C" if it helps but I'm still challenging the idea it's actually going to work.

[Frityet]

Objective C is fully ABI compatible with C, and each C function (not methods) use the C ABI. If required I will do that, but it will be the same result

[Frityet]

                 U _OBJC_CLASS_$_OFConstantString
                 U _OFStdOut
0000000100000000 T __mh_execute_header
0000000100003f30 T _fn
0000000100003f60 T _main
                 U _objc_msgSend
                 U dyld_stub_binder

from this

#import <ObjFW/OFStdIOStream.h>

void fn(OFString *str)
{
	[OFStdOut writeLine: str];
}

int main()
{
	[OFStdOut writeLine: @"Calling!"];
	fn(@"Called!");
}

[Frityet]

Same result on linux

[tseli0s]

Okay, I guess I'll leave that to you.

[tseli0s]

I'll fix the CMake script to compile, I hope you can test if it actually compiles.
ED: Made the first commits, I'll set up CI later to test automatically.

[Frityet]

I'll fix the CMake script to compile, I hope you can test if it actually compiles. ED: Made the first commits, I'll set up CI later to test automatically.

The objc code def compiles and works, for I have used it for previous projects

[Frityet]

Still trying to build for GTK4 :/

GTK 4 runs on MacOS btw

[tseli0s]

While it does, you can skip it altogether because the whole point of NvDialog is to use Cocoa in this case, or the native UI library in general on each system.

[Frityet]

While it does, you can skip it altogether because the whole point of NvDialog is to use Cocoa in this case, or the native UI library in general on each system.

How do I make it build with cocoa though

[Frityet]

Update: figured it out!

[Frityet]

[tseli0s]

Looks like we've got most of the work away. However I noticed you enabled the libadwaita backend too. You need to disable it:

How do I make it build with cocoa though

Since the previous changes I made in CMakeLists.txt, if macOS is detected it will automatically use Cocoa.

[Frityet]

@AndroGR with the exeception of "about" and notifications, the PR should be ready

[tseli0s]

For the about dialog part, is there a ready to use Cocoa function? Because otherwise you can skip it for now and make it return NULL when called.

[tseli0s]

Also, make sure to sync with master, there are some conflicts because you are using the older version of the tests/ folder.

[Frityet]

For the about dialog part, is there a ready to use Cocoa function?

Nope, none from what I have seen

[Frityet]

Done, ready to be merged

[Frityet]

nvm found out how to make about windows

[Frityet]

it is done

[tseli0s]

Merging, thanks for the contribution!