feat(barrels): use eslint sorting order #476
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Romakita
reviewed
Apr 15, 2025
| @@ -12,7 +22,7 @@ async function generateIndex(directory, {cwd, excluded, noSemicolon}) { | |||
| }); | |||
|
|
|||
| const exports = files | |||
| .sort((a, b) => a.localeCompare(b)) | |||
| .sort((a, b) => compare(a, b)) | |||
| .map((file) => { | |||
| // TODO set .js after all configuration are ok to resolve .js | |||
| return `export * from "./${file.replace(".ts", ".js")}"${noSemicolon ? "" : ";"}`; | |||
There was a problem hiding this comment.
the best option is to add a comment to like // eslint-disable or something equivalent or just add generated index.ts to eslint ignore rules.
There was a problem hiding this comment.
or just add auto fix on commit using husky.
There was a problem hiding this comment.
Because if the project use biome.js or prettier, this sorting won't potentially be the same.
There was a problem hiding this comment.
You might be right. I was just thinking that most cases (even with prettier) the eslint sorting order would be the one used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use eslint sorting