Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecation expectations - fixes #51 #53

Merged
merged 3 commits into from
Nov 13, 2019
Merged

Add deprecation expectations - fixes #51 #53

merged 3 commits into from
Nov 13, 2019

Conversation

SamVerschueren
Copy link
Collaborator

Want to review it myself as well. But this should resolve #51.

// @sindresorhus @cartant

sindresorhus
sindresorhus requested changes Nov 8, 2019
View reviewed changes
readme.md Outdated Show resolved Hide resolved
@SamVerschueren
Copy link
Collaborator Author

Updated. Great tip!

Do we want to add examples in the readme.md per assertion? So it's clear what it does. Wanted to keep the Assertions part small because you want to easily see an overview of all the different possibilities.

I find it quite hard to write documentation for larger projects :p.

@SamVerschueren SamVerschueren merged commit 97261b2 into master Nov 13, 2019
@SamVerschueren SamVerschueren deleted the iss51 branch November 13, 2019 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecation expectations
2 participants
@SamVerschueren @sindresorhus