Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore more diagnostics with expectError #17

Conversation

BendingBender
Copy link
Collaborator

@BendingBender BendingBender commented Mar 17, 2019

ignoreError should ignore more diagnostic errors:

  • "property does not exist on type"
  • "cannot assign to read-only property"

This PR adds the according diagnostic codes and filters them away when diagnostic is reported to be in an expectError statement.

@BendingBender BendingBender changed the title Ignore property does not exist diagnostics with expectError Ignore "property does not exist" diagnostics with expectError Mar 17, 2019
@BendingBender BendingBender force-pushed the ignore-property-does-not-exist-diagnostic branch from 0bb74e5 to 2f5ea25 Compare March 17, 2019 15:06
@BendingBender BendingBender changed the title Ignore "property does not exist" diagnostics with expectError Ignore more diagnostics with expectError Mar 17, 2019
@SamVerschueren SamVerschueren merged commit 1c6bcfb into tsdjs:master Mar 19, 2019
@SamVerschueren
Copy link
Collaborator

Awesome! 🍻

@BendingBender BendingBender deleted the ignore-property-does-not-exist-diagnostic branch March 19, 2019 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants