fix(strictest)!: don't implicitly allow js in strictest config #332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes
checkJsfrom thestrictestconfiguration.The
strictestconfig currently enablescheckJs. Since TypeScript 4.1, whenallowJsis not explicitly defined, its value is inferred fromcheckJs. This results instrictestimplicitly settingallowJs: true, which can lead to unexpected behavior and conflicts with other compiler options.For example, using
strictestwithisolatedDeclarations: truecauses the following error becauseallowJsandisolatedDeclarationscannot be used together:This change removes
checkJsfrom thestrictestconfiguration to preventallowJsfrom being enabled by default.For reference, here's the code