Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node19 base #176

Merged
merged 2 commits into from
Apr 21, 2023
Merged

Node19 base #176

merged 2 commits into from
Apr 21, 2023

Conversation

RobinTail
Copy link
Contributor

Closes #142

Node 19 base

After examination of https://node.green/ I found out that Node 19 capabilities are equal to Node 18.

Version 1

Due to this issue: #173 I'm making the version 1 first, having "lib": ["es2022"], in order to support Typescript below version 5.
After that version 2 can be released similar to what Node 18 base looks like currently (having es2023 lib).

@RobinTail RobinTail marked this pull request as ready for review April 21, 2023 10:18
@RobinTail
Copy link
Contributor Author

I'm not sure if any extra work is required.

@orta , please review.

@orta
Copy link
Member

orta commented Apr 21, 2023

Yeah, this seems reasonable to me, deploys happen overnight - so if you send the PR for 2.0 today, I'll merge tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Node.js v19 bases
2 participants