fix: prevent false obstacle rejection by linking MST sub-routes to parent nets #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
0hmX
changed the title
seveibar
reviewed
Dec 9, 2025
seveibar
reviewed
Dec 9, 2025
Contributor
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
everything about this is good except for the name. originalConnectionName or rootConnectionName is far better, net id doesn't exist as a term and increases the complexity of understanding the autorouter
Contributor
|
traces are now improved for e2e3 ❤️ 
|
seveibar
reviewed
Dec 10, 2025
lib/solvers/AssignableViaAutoroutingPipeline/AssignableViaAutoroutingPipelineSolver.ts
Outdated
Show resolved
Hide resolved
seveibar
reviewed
Dec 10, 2025
lib/solvers/AssignableViaAutoroutingPipeline/OffboardPathFragmentSolver.ts
Outdated
Show resolved
Hide resolved
seveibar
reviewed
Dec 10, 2025
lib/solvers/CapacityMeshSolver/CapacityEdgeToPortSegmentSolver.ts
Outdated
Show resolved
Hide resolved
…prevent false obstacle rejections fix(autorouter): correctly link merged MST connections to parent nets docs(report): Add verification section to obstacle rejection bug fix report chore(debug): add connectivity map logs for verification feat(svg): Update SVG snapshots refactor(names): Transitioned to property-based connection naming and updated test snapshot fix(test): Update repro01-highdensity-drc-failure.test.ts for snapshot change chore(docs): remove bug fix report chore(cleanup): remove debug console logs chore(format): Apply code formatting WIP WIP
0hmX
force-pushed
the
fix/valid-path-not-accepted
branch
from
7f7ed26 to
f5660a7
Compare
seveibar
approved these changes
Dec 10, 2025
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The autorouter was incorrectly rejecting valid paths as "obstacle
intersections." This happened because when a net was split into Minimum
Spanning Tree (MST) segments (e.g., net_mst0), the connectivity solver didn't
link these sub-segments back to the original net name (e.g., net) used by
destination pads.
Solution:
pipeline (NetToPointPairsSolver, CapacityPath, SimpleRouteConnection,
etc.).
their parentNetId and mergedConnectionNames.
this property-based approach.
This ensures the solver correctly identifies destination pads as valid
connections, not obstacles.