add edge margin props to panel #528
Conversation
imrishabh18
left a comment
imrishabh18
left a comment
There was a problem hiding this comment.
Margin is pretty confusing, it could also mean margin between two boards which are in the same panel. From the image it seems you want the edge margin, so something like edgeMarginRight or edgePaddingRight seems appropriate to me.
ShiboSoftwareDev
force-pushed
the
main
branch
from
2d07e9a to
66d2d13
Compare
ShiboSoftwareDev
changed the title
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
when something is an inner margin its a padding. edgePadding seems okay
slightly worried about the interaction between this prop and tooling rails but we’ll figure it out
ShiboSoftwareDev
force-pushed
the
main
branch
from
fdf7db6 to
321b79b
Compare
|
Thank you for your contribution! 🎉 PR Rating: ⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
1 similar comment
|
Thank you for your contribution! 🎉 PR Rating: ⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
4 participants
Is this good naming for customizing that margin?
