Handle board-relative anchor offsets #447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Size ReportBundle Size
Install Size
Full Howfat Output (PR Branch) |
Size ReportBundle Size
Install Size
Full Howfat Output (PR Branch) |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+385
to
+391
| const baseValue = displayOffset ?? offsetMm.toFixed(2) | ||
| const valueStr = | ||
| typeof baseValue === "number" ? baseValue.toString() : baseValue | ||
| const hasUnit = typeof valueStr === "string" && valueStr.trim().endsWith("mm") | ||
| const unitSuffix = hasUnit ? "" : "mm" | ||
|
|
||
| return `${axis}: ${valueStr}${unitSuffix}` |
Contributor
There was a problem hiding this comment.
The function doesn't handle empty string displayOffset properly. If displayOffset is an empty string "", the nullish coalescing operator (??) will use it instead of falling back to the calculated value, resulting in labels like "X: mm" or "Y: mm".
Fix:
function formatOffsetLabel(
axis: "X" | "Y",
offsetMm: number,
displayOffset?: number | string,
): string {
const baseValue = displayOffset ?? offsetMm.toFixed(2)
const valueStr =
typeof baseValue === "number" ? baseValue.toString() : baseValue
// Handle empty strings
if (typeof valueStr === "string" && valueStr.trim() === "") {
return `${axis}: ${offsetMm.toFixed(2)}mm`
}
const hasUnit = valueStr.trim().endsWith("mm")
const unitSuffix = hasUnit ? "" : "mm"
return `${axis}: ${valueStr}${unitSuffix}`
}
Suggested change
| const baseValue = displayOffset ?? offsetMm.toFixed(2) | |
| const valueStr = | |
| typeof baseValue === "number" ? baseValue.toString() : baseValue | |
| const hasUnit = typeof valueStr === "string" && valueStr.trim().endsWith("mm") | |
| const unitSuffix = hasUnit ? "" : "mm" | |
| return `${axis}: ${valueStr}${unitSuffix}` | |
| const baseValue = displayOffset ?? offsetMm.toFixed(2) | |
| const valueStr = | |
| typeof baseValue === "number" ? baseValue.toString() : baseValue | |
| // Handle empty strings | |
| if (typeof valueStr === "string" && valueStr.trim() === "") { | |
| return `${axis}: ${offsetMm.toFixed(2)}mm` | |
| } | |
| const hasUnit = typeof valueStr === "string" && valueStr.trim().endsWith("mm") | |
| const unitSuffix = hasUnit ? "" : "mm" | |
| return `${axis}: ${valueStr}${unitSuffix}` |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
1 similar comment
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Codex Task