-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use glob and fs instead of Grunt, fixes #2 #7
Conversation
EDIT: I've fixed the broken Travis build for Node v0.8 by updating npm before installing dependencies. |
Nice. Was going to suggest the same. Unfortunate to have to do this, but until a new 0.8 is out, everybody will have to patch it. |
@@ -70,23 +71,24 @@ exports.publish = function publish(config, done) { | |||
// override defaults with any task options | |||
var options = _.extend({}, defaults, config); | |||
|
|||
if (!grunt.file.isDir(options.base)) { | |||
if (!fs.statSync(options.base).isDirectory()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since statSync
will throw if options.base is undefined or it doesn't exist, this would have to be wrapped in try/catch
to maintain previous behavior.
Looks good @markdalgleish. One minor comment on error handling with a bad |
I've wrapped the Since ghpages.publish(basePath, options, callback); |
One change this introduces is that the
That sounds good to me (also can be done separately). |
Use glob and fs instead of Grunt, fixes #2.
No description provided.