Fix remove not working properly

[sunghwan2789]

This PR fixes some issues described below and resolves #334, fixes #337 .

Remove globbed files

gh-pages/lib/index.js

Line 156 in 3579ab2

return git.rm(only.join(' '));

Joining files in a string causes incorrect shell argument passing. A globbed file can be removed, but globbed files cannot be removed since the actual command will be

git rm -r -f "abc.js abc.css"

This PR makes git.rm and git.add accept string[] and handle them properly.

Remove files in remote dist directory, not in local one

gh-pages/lib/index.js

Lines 97 to 99 in 3579ab2

	const only = globby.sync(options.only, {cwd: basePath}).map(file => {
	return path.join(options.dest, file);
	});

This shows that gh-pages globs files to be removed in local dist directory, not in remote branch. It causes git a fatal error(like #337) since it tries to remove files that are not in remote dist directory. globby.sync should be executed in remote dist directory.

Skip removing files if there are no globbed files

When globby.sync globs files, it returns empty array if there are no files to be removed. A guard of it should be added before

gh-pages/lib/index.js

Line 156 in 3579ab2

return git.rm(only.join(' '));

[codler]

I encountered this bug also #337, i hope this will be merged

[tschaub]

Thanks for the proposed fix, @sunghwan2789.

Can you please remove the added .prettierrc file? Formatting is handled by ESLint, and editor integrations should be able to use the eslintConfig member already in the package.json.

[sunghwan2789]

Oh I did not notice that. Removed now!

[tschaub]

This default scares me. I haven't found time to do a more thorough review, but I don't get why we would want to remove everything by default.

[tschaub]

Scratch that, I see that is the currently documented behavior. Clearly I need to get my head back into this before understanding if this change does the right thing.

[sunghwan2789]

I think removing all files default seems ok to me, as options.add is present for controlling this behaviour.
For a reference, please take a look https://github.com/marketplace/actions/github-pages-action#%EF%B8%8F-keeping-existing-files

[tschaub]

Thanks for your work on this, @sunghwan2789.